Skip to content

London | 26-ITP-Sep | Mandip Sanger| Sprint 3 | Quote generator - #1456

Open
mandipsanger wants to merge 10 commits into
CodeYourFuture:mainfrom
mandipsanger:quote-generator
Open

London | 26-ITP-Sep | Mandip Sanger| Sprint 3 | Quote generator#1456
mandipsanger wants to merge 10 commits into
CodeYourFuture:mainfrom
mandipsanger:quote-generator

Conversation

@mandipsanger

@mandipsanger mandipsanger commented Aug 21, 2026 •
edited
Loading

Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Task Code

CYF-1096

Changelist

Quote generator app

@mandipsanger mandipsanger added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 21, 2026
@mandipsanger

mandipsanger commented Aug 21, 2026

Copy link
Copy Markdown
Author

I have already made pr to this but couldnot find it may be in coursework so doing it now again

@mandipsanger mandipsanger mentioned this pull request Aug 21, 2026
Open
LonMcGregor
LonMcGregor reviewed Sep 1, 2026
View reviewed changes

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The app works, but you should not change parts of the code that are not intended to be changed. If you removed quotes for testing, can you restore them when opening the PR?

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 1, 2026
@mandipsanger mandipsanger changed the title London | 26-ITP-May | Mandip Sanger| Sprint 3 | Quote generator London | 26-ITP-Sep | Mandip Sanger| Sprint 3 | Quote generator Sep 9, 2026
@mandipsanger

mandipsanger commented Sep 14, 2026

Copy link
Copy Markdown
Author

could you please point out which one is change. Is it in Array of objects with two properties authour and quote. Are there any quotes missing? I can add or replace from original.

@mandipsanger
Add new motivational quotes to quotes array
ac6814f 
Added multiple quotes to the quotes array while preserving the existing structure. The new quotes include various authors and motivational messages.
@mandipsanger mandipsanger added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Sep 14, 2026
@LonMcGregor

LonMcGregor commented Sep 15, 2026

Copy link
Copy Markdown

When I test this, now the app does not work. I only see an empty page and there are no quotes. Have you fully tested this before you updated the PR?

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 15, 2026
@mandipsanger

mandipsanger commented Sep 16, 2026

Copy link
Copy Markdown
Author

Thanks for pointing out. My program was working before I have even given demo on it, somehow I think it got deleted. I have fixed the issue and tested app is working now. Please test if its showing on the remote. Somehow when I am opening the old pull request its giving me problems.

@mandipsanger mandipsanger added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Sep 16, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 16, 2026
@github-actions

This comment has been minimized.

Sign in to view
@mandipsanger mandipsanger added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 16, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 16, 2026
@mandipsanger mandipsanger added NotCoursework Not coursework - used for curriculum development work. Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 16, 2026
LonMcGregor
LonMcGregor reviewed Sep 21, 2026
View reviewed changes

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, the quote generator works now!

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. NotCoursework Not coursework - used for curriculum development work. labels Sep 21, 2026
@github-actions

github-actions Bot commented Sep 21, 2026

Copy link
Copy Markdown

The files changed in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the 'files changed' tab at the top of the page.

Here is an example of a file that has been changed on this branch but shouldn't be: Sprint-1/fix/median.js

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

2 similar comments
@github-actions

github-actions Bot commented Sep 21, 2026

Copy link
Copy Markdown

The files changed in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the 'files changed' tab at the top of the page.

Here is an example of a file that has been changed on this branch but shouldn't be: Sprint-1/fix/median.js

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@github-actions

github-actions Bot commented Sep 21, 2026

Copy link
Copy Markdown

The files changed in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the 'files changed' tab at the top of the page.

Here is an example of a file that has been changed on this branch but shouldn't be: Sprint-1/fix/median.js

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LonMcGregor LonMcGregor LonMcGregor left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mandipsanger @LonMcGregor